[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 13:36:49 PDT 2020


awarzynski updated this revision to Diff 301414.
awarzynski added a comment.

Remove the diagnostic

- Deleted the `err_drv_invalid_Xarch_argument_unsupported` diagnostic
- Removed `const` from &getDiags() - otherwise I couldn't use `getCustomDiagID` (which is a non-const member function). `DiagnosticEngine` is a non-const member variable of `clang::driver::Driver`, so this change should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89799/new/

https://reviews.llvm.org/D89799

Files:
  clang/include/clang/Basic/DiagnosticDriverKinds.td
  clang/include/clang/Driver/Driver.h
  clang/include/clang/Driver/Options.h
  clang/include/clang/Driver/Options.td
  clang/lib/Driver/ToolChain.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89799.301414.patch
Type: text/x-patch
Size: 76326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201028/74433f86/attachment-0001.bin>


More information about the cfe-commits mailing list