[PATCH] D31363: [libc++] Remove cmake glob for source files

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 13:09:09 PDT 2020


ldionne added a comment.

In D31363#2360132 <https://reviews.llvm.org/D31363#2360132>, @ldionne wrote:

> This patch isn't necessary anymore, as we don't use globing anymore. Let's abandon it to clean up the review queue.

Actually, I misspoke. We still use it, but only in a few places. If you still feel that we should fix this, please rebase onto `master` and I will review. Otherwise, let's close this review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D31363/new/

https://reviews.llvm.org/D31363



More information about the cfe-commits mailing list