[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

Amy Kwan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 10:27:18 PDT 2020


amyk added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:3310
 
+// Check that the given type is a valid type for the PPC target. Return true
+// if the type is invalid.
----------------
Would this be a better comment for this function (since it may be confusing to say return true if the type is invalid but the function name is `CheckPPCValidType`?
```
// Check if the given type is a non-pointer PPC MMA type. This function is used
// in Sema to prevent invalid uses of restricted PPC MMA types.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82035/new/

https://reviews.llvm.org/D82035



More information about the cfe-commits mailing list