[PATCH] D81748: [PowerPC] Add MMA builtin decoding and definitions

Amy Kwan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 10:01:08 PDT 2020


amyk added inline comments.


================
Comment at: clang/include/clang/AST/ASTContext.h:2050
 
+  QualType DecodeTypeStr(const char *&Str, const ASTContext &Context,
+                         ASTContext::GetBuiltinTypeError &Error,
----------------
I think it might be good to add a small comment here/in `ASTContext.cpp` for this function (in how we use it to fall back to default type handling).


================
Comment at: clang/include/clang/Basic/BuiltinsPPC.def:674
+// The third argument is set to true if the builtin accumulates its result into
+// its given accumulator accumulator.
+
----------------
Remove the extra `accumulator`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81748/new/

https://reviews.llvm.org/D81748



More information about the cfe-commits mailing list