[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

[Aaron Puchert via Phabricator via cfe-commits]

aaronpuchert added a comment.

Can't really add anything to the discussion between @Quuxplusone and the author, just a few comments about the test.



================
Comment at: clang/test/SemaCXX/implicitly-movable.cpp:1
+// RUN: %clang_cc1 -std=c++20 -fsyntax-only -fcxx-exceptions -verify %s
+// RUN: %clang_cc1 -std=c++17 -fsyntax-only -fcxx-exceptions -verify %s
----------------
Could you perhaps integrate this into the existing test `clang/test/CXX/special/class.copy/implicit-move.cpp` instead? Whenever you have something that closely corresponds to the standard, `CXX` is probably the right place for a test.


================
Comment at: clang/test/SemaCXX/implicitly-movable.cpp:14
+
+private:
+  A(const A &);
----------------
Is this testing what we want it to test? The private functions are just not part of the overload set, right?

I think you should make them public and `= delete` them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88295/new/

https://reviews.llvm.org/D88295