[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=<file-path>" to specify custom config file

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 10:49:40 PDT 2020


njames93 added a comment.

If you plan on contributing quite a lot then it would be wise to upload your patches with arcanist - https://llvm.org/docs/Phabricator.html. It will help prevent issues with diffs being relative to previous revisions.
Personally I just create a branch from master for a feature. When I create the patch or update, I just need to use `arc diff master` and it will handle everything for me.
The other advantage of using arc for patches is the pre-merge bot is then able to build and check your patch to make sure all tests pass.



================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:290
   DefaultOptions.Checks = DefaultChecks;
+  DefaultOptions.ConfigFile = "";
   DefaultOptions.WarningsAsErrors = "";
----------------
Given you've removed the references to `ConfigFile` in `ClangTidyOptions.h` this should surely result in a compiler error, same goes below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89936/new/

https://reviews.llvm.org/D89936



More information about the cfe-commits mailing list