[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

Tue Oct 27 10:14:24 PDT 2020

Szelethus added a comment.

In D89987#2350649 <https://reviews.llvm.org/D89987#2350649>, @NoQ wrote:

> Honestly i'd rather eliminate `SymExpr` and go with `Symbol` everywhere. It's an overloaded term but appending "Expr" to it doesn't really make it significantly less overloaded.

Why? I think calling it `Symbol` would make the situation a lot worse. We have symbolic expressions, values, memory regions, why shouldn't we dedicate a name to each?

> "Symbol" is catchy and it's one of the most important concepts to grasp in the static analyzer, i'd love to keep it.

Hmm, am I lacking some prerequisite knowledge that would make sense out of calling this `Symbol`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89987/new/

https://reviews.llvm.org/D89987