[PATCH] D88566: be more specific when testing for no fuse-ld warnings
Ties Stuij via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 27 09:46:49 PDT 2020
stuij added a comment.
> If this cannot be reproduced with the OSS LLVM, I am not sure you should adjust such a test.
Ok, fair enough. Thanks for the comment.
================
Comment at: clang/test/Driver/fuse-ld.c:15
// RUN: FileCheck %s --check-prefix=CHECK-NO-WARN
-// CHECK-NO-WARN-NOT: warning:
+// CHECK-NO-WARN-NOT: warning: 'fuse-ld'
----------------
MaskRay wrote:
> stuij wrote:
> > MaskRay wrote:
> > > How does this line trigger unrelated warnings? Can you dump it?
> > see my top-level comment
> The impoerant bit is that the original message disallows any warning. The new message with an incorrect 'fuse-ld' (instead of '-fuse-ld') seems really questionable.
Ai, a typo :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88566/new/
https://reviews.llvm.org/D88566
More information about the cfe-commits
mailing list