[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a comment.

Unfortunately, the patch does not apply against llvm9 (which is what we have as experimental setup) not to speak against llvm5 which is our production setup.

Is the performance overhead for loaded module a % of the overall size of the source files?

Sorry for the naive question but what is a unloaded module?



================
Comment at: clang/include/clang/Basic/SourceManager.h:703
-  /// Same indexing as LoadedSLocEntryTable.
-  llvm::BitVector SLocEntryLoaded;
 
----------------
We can probably remove the bitvector header include.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89749/new/

https://reviews.llvm.org/D89749