[PATCH] D89980: [hip] Remove kernel argument coercion.
Michael Liao via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 27 09:29:04 PDT 2020
hliao added inline comments.
================
Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19
+// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x)
+// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4
// OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1
----------------
arsenm wrote:
> This is still a regression. Fixing up AA does not solve the problem this promotions this is intended to solve. Generic accesses are worse independently of the aliasing properties
Do you mean FLAT load/store has worse addressing mode than GLOBAL ones?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89980/new/
https://reviews.llvm.org/D89980
More information about the cfe-commits
mailing list