[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 09:25:31 PDT 2020

Previous message: [PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations
Next message: [PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

arphaman added a comment.

What's wrong with using `Optional<FileEntryRef>` instead of `MaybeFileEntryRef`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89834/new/

https://reviews.llvm.org/D89834

Previous message: [PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations
Next message: [PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list