[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 08:13:42 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:42
+
+llvm::Optional<FoldingRange> toFoldingRange(LocInfo Begin, LocInfo End,
+                                            const SourceManager &SM) {
----------------
just use SourceLocations or SourceRange here? We have the SourceManager to decompose them anyway.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88553/new/

https://reviews.llvm.org/D88553



More information about the cfe-commits mailing list