[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 27 03:04:29 PDT 2020
kadircet added inline comments.
================
Comment at: llvm/cmake/modules/FindGRPC.cmake:117
+ # Ensure dependency headers are generated before dependent protos are built.
+ # FIXME: CMake docs suggest OBJECT_DEPENDS isn't needed, but I can't get the
+ # recommended add_dependencies() approach to work.
----------------
nit: I would move the fixme near to the `set_source_files_properties`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90215/new/
https://reviews.llvm.org/D90215
More information about the cfe-commits
mailing list