[PATCH] D89851: [clangd] Separate final_result into a different message

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:15
 
+message FinalResult { optional bool has_more = 1; }
+
----------------
this deserves a comment: "Common final result for streaming requests."


================
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:15
 
+message FinalResult { optional bool has_more = 1; }
+
----------------
sammccall wrote:
> this deserves a comment: "Common final result for streaming requests."
this isn't specific to Lookup, so shouldn't go between LookupRequest and LookupReply, rather either at the very top or below all the request/reply messages.


================
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:22
     Symbol stream_result = 1;
-    bool final_result = 2;
+    FinalResult result = 2;
   }
----------------
I think stream_result/result suggests that `result` is "primary" which isn't the case.
I think the old names stream_result/final_result were clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89851/new/

https://reviews.llvm.org/D89851