[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tue Oct 27 02:30:48 PDT 2020

Tyker added a comment.

In D88645#2353152 <https://reviews.llvm.org/D88645#2353152>, @thakis wrote:

> Looks like this broke tests: http://45.33.8.238/linux/31159/step_12.txt
>
> Please take a look, and revert for now if it takes a while to fix.

this is fixed by 4afa077899b <https://reviews.llvm.org/rG4afa077899b1e3def4cff475deae73681db04e21>

In D88645#2354196 <https://reviews.llvm.org/D88645#2354196>, @john.brawn wrote:

> This also causes the AnnotateFunctions example to no longer build:
>
>   /home/jb/work/llvm-project/clang/examples/AnnotateFunctions/AnnotateFunctions.cpp: In member function ‘virtual bool {anonymous}::AnnotateFunctionsConsumer::HandleTopLevelDecl(clang::DeclGroupRef)’:
>   /home/jb/work/llvm-project/clang/examples/AnnotateFunctions/AnnotateFunctions.cpp:36:70: error: no matching function for call to ‘clang::AnnotateAttr::CreateImplicit(clang::ASTContext&, const char [19])’
>                                                     "example_annotation"));
>                                                                         ^
>
> it looks like it needs to be adjusted for the extra variadic arg that the attribute now has.

this is fixed by 2618247c61c <https://reviews.llvm.org/rG2618247c61c25cf9bd4cb315ee51cff2b3ab3add>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88645/new/

https://reviews.llvm.org/D88645