[PATCH] D90163: [Syntax] Disallow invalid Node operations
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 27 00:36:55 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc6a05eb62f2a: [Syntax] Disallow invalid Node operations (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90163/new/
https://reviews.llvm.org/D90163
Files:
clang/include/clang/Tooling/Syntax/Tree.h
Index: clang/include/clang/Tooling/Syntax/Tree.h
===================================================================
--- clang/include/clang/Tooling/Syntax/Tree.h
+++ clang/include/clang/Tooling/Syntax/Tree.h
@@ -76,10 +76,20 @@
/// A node in a syntax tree. Each node is either a Leaf (representing tokens) or
/// a Tree (representing language constructrs).
class Node {
-public:
+protected:
/// Newly created nodes are detached from a tree, parent and sibling links are
/// set when the node is added as a child to another one.
Node(NodeKind Kind);
+ /// Nodes are allocated on Arenas; the destructor is never called.
+ ~Node() = default;
+
+public:
+ /// Nodes cannot simply be copied without violating tree invariants.
+ Node(const Node &) = delete;
+ Node &operator=(const Node &) = delete;
+ /// Idiomatically, nodes are allocated on an Arena and never moved.
+ Node(Node &&) = delete;
+ Node &operator=(Node &&) = delete;
NodeKind getKind() const { return static_cast<NodeKind>(Kind); }
NodeRole getRole() const { return static_cast<NodeRole>(Role); }
@@ -153,7 +163,6 @@
/// A node that has children and represents a syntactic language construct.
class Tree : public Node {
public:
- using Node::Node;
static bool classof(const Node *N);
Node *getFirstChild() { return FirstChild; }
@@ -170,6 +179,7 @@
}
protected:
+ using Node::Node;
/// Find the first node with a corresponding role.
Node *findChild(NodeRole R);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90163.300908.patch
Type: text/x-patch
Size: 1478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201027/3649917f/attachment.bin>
More information about the cfe-commits
mailing list