[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 22:49:00 PDT 2020


nridge added a comment.

In D90134#2352932 <https://reviews.llvm.org/D90134#2352932>, @kadircet wrote:

>> My experience using this feature in real codebases has been that we take this early-exit too often; the limit of 3 is fairly easy to hit due to things like layers of wrappers that repeat a function name. Bumping the limit to 5 has increased the usefulness for me.
>
> What about counting number of different files, rather than number of symbols ?

If you mean counting the number of different files but keeping the limit at 3, I don't think that would change much; in my experience, you often have wrappers that repeat the same names in a different file than the functions they are wrapping.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90134/new/

https://reviews.llvm.org/D90134



More information about the cfe-commits mailing list