[PATCH] D90010: clang-tidy: Reduce number of stderr write calls
Hiral via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 26 20:20:10 PDT 2020
Hiralo added a comment.
In D90010#2352556 <https://reviews.llvm.org/D90010#2352556>, @njames93 wrote:
> Isn't `llvm::errs()` buffered, negating most of the benefit here.
If it is buffered, we would expect single write call to stderr. But we are seeing 7 write calls!
Yes, please suggest how to make llvm::errs() buffered that will be easy patch :)
In D90010#2352627 <https://reviews.llvm.org/D90010#2352627>, @dblaikie wrote:
> (the patch description doesn't explain any specific motivation either - whether it's performance (runtime? memory usage? etc?) or something else, and how the performance aspect has been quantified)
The motivation is to avoid 7 write calls which helps in large build system and easy on NFS!
Thank you.
-Hiral
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90010/new/
https://reviews.llvm.org/D90010
More information about the cfe-commits
mailing list