[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 17:28:53 PDT 2020


njames93 added a comment.

Taking a step back, clang-tidy checks are supposed to enforce guidelines for the specific module they live in.
If there are 10'000 occurrences of a semi directly after a switch closing brace in the linux kernel code base it could be argued that its a style guideline of the code base (or something they don't feel too strongly about).
In any case this check wouldn't be enforcing any guideline for the linux kernel code base.

Having said that, given it occurs so many times in one specific code base, suggests it may appear many more times in the wild.
In which case a specific warning should be emitted, just not in the linux-kernel module (or clang-tidy???)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90180/new/

https://reviews.llvm.org/D90180



More information about the cfe-commits mailing list