[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith updated this revision to Diff 300811.
dexonsmith added a comment.

Updated to address remaining review comments.

Note that we discussed double-redirection use case offline, and agreed it doesn't come up in practice (even with multiple RedirectingFileSystem layers) so we shouldn't support it. I added a targeted assertion and added an `EXPECT_DEATH` with a comment in the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89488/new/

https://reviews.llvm.org/D89488

Files:
  clang/include/clang/Basic/FileManager.h
  clang/lib/Basic/FileManager.cpp
  clang/lib/Basic/SourceManager.cpp
  clang/unittests/Basic/FileManagerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89488.300811.patch
Type: text/x-patch
Size: 19113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201026/6f3e04d7/attachment-0001.bin>