[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 09:20:57 PDT 2020


eduucaldas marked an inline comment as done.
eduucaldas added a comment.

In D90161#2353736 <https://reviews.llvm.org/D90161#2353736>, @gribozavr2 wrote:

> Could you add tests that verify the pairing of elements and delimiters?

Those are surfaced through the previous tests, via `getElementsAsNodesAndDelimiters`



================
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:442
+  ElementAndDelimiterIterator<Node>
+  getElementsAsNodesAndDelimitersBeforeBegin();
+  ElementAndDelimiterIterator<Node> getElementsAsNodesAndDelimitersBegin();
----------------
What do you think?

I didn't change it, because we had agreed on `ElementsAsNodesAndDelimiters`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90161/new/

https://reviews.llvm.org/D90161



More information about the cfe-commits mailing list