[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 01:44:30 PDT 2020


krasimir added a comment.

This looks reasonable.

I'm curious about DiagnosticsEngine: previously we were using the defaults for `client` and `ShouldOwnClient` ctor params (`nullptr` and `true`). If this usage leads to crashes, isn't the issue in `DiagnosticsEngine` itself?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90121/new/

https://reviews.llvm.org/D90121



More information about the cfe-commits mailing list