[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 26 00:07:46 PDT 2020
gribozavr2 added inline comments.
================
Comment at: clang/include/clang/AST/CommentLexer.h:244
+ /// command, including command marker.
+ SmallString<16> VerbatimBlockEndCommandName;
+
----------------
I'm not a fan of this change to `Lexer` because it breaks the grouping of fields: `VerbatimBlockEndCommandName` is no longer next to `State`.
There is only ever one `Lexer` class instance anyway, so any memory savings are not important I think.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90127/new/
https://reviews.llvm.org/D90127
More information about the cfe-commits
mailing list