[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 25 10:49:13 PDT 2020


ArcsinX added a comment.

I have face this problem long time ago.
This happens only:

- on non-English Windows (and could be fixed via system settings: Control Panel -> Clock,Language,and Region -> Region and Language -> Administrative ->Language for non-Unicode programs -> Change system locale -> English).
- with Visual Studio Compiler

Seems, there are other places in LLVM with this problem (unsure that this is a complete list):
https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp#L53
https://github.com/llvm/llvm-project/blob/master/llvm/unittests/Support/JSONTest.cpp#L240


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90116/new/

https://reviews.llvm.org/D90116



More information about the cfe-commits mailing list