[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 23 18:30:06 PDT 2020


dexonsmith marked an inline comment as done.
dexonsmith added a comment.

Committed in 434f3774f629f5896614e9efb4eda82d813402ed <https://reviews.llvm.org/rG434f3774f629f5896614e9efb4eda82d813402ed>.



================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222
       if (File)
         // FIXME: Use correctly named FileEntryRef.
+        Delegate->FileSkipped(*File, SynthesizedFilenameTok, Inc.FileKind);
----------------
arphaman wrote:
> You can drop the FIXME here now.
Good point, fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89514/new/

https://reviews.llvm.org/D89514



More information about the cfe-commits mailing list