[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 23 10:21:34 PDT 2020


dexonsmith added inline comments.


================
Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088
+  ID.Add(Range.getEnd());
+  ID.Add(static_cast<const SourceLocation &>(Loc));
 }
----------------
I'm surprised you need this `static_cast`, can you explain why it was necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69844/new/

https://reviews.llvm.org/D69844



More information about the cfe-commits mailing list