[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

In D89971#2347909 <https://reviews.llvm.org/D89971#2347909>, @tra wrote:

>> The template overload
>
> function overload.
>
>> is still hidden behind an ifdef for OpenMP. In the
>> future we probably want to remove the ifdef but that requires further
>> testing.
>
> I don't think it's the case.  I've just ran `clang++ -x cuda /dev/null  --cuda-host-only -dD -E ` and I do see the definitions for `tanh` just above your change.

My comment was about the template I point out in the inline comment below. Also I was talking about the OpenMP declare variant overloads, not the cuda definitions.
TBH, I don't understand what you want to tell me with the remark about the cuda definitions and `tanh`. Nothing the OpenMP stuff does should impact cuda and tanh was there already, I'm confused :(



================
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:330
     double>::type
 remquo(__T1 __x, __T2 __y, int *__quo) {
   return std::remquo((double)__x, (double)__y, __quo);
----------------
The template overload I was talking about is this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89971/new/

https://reviews.llvm.org/D89971