[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 22 11:43:27 PDT 2020
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60
+ llvm::StringRef Path(this->RemoteIndexRoot);
if (!Path.endswith(PosixSeparator))
+ this->RemoteIndexRoot += PosixSeparator;
----------------
nit: `if(!is_separator(this->RemoteIndexRoot.back(), posix))` same below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89852/new/
https://reviews.llvm.org/D89852
More information about the cfe-commits
mailing list