[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 22 11:33:50 PDT 2020
kadircet added a comment.
> I thought the point of the comment was us not handling it properly rather than LSP not supporting it (e.g. LSP does support Operator but we do not). Then, the comment about ctor and dtor being indistinguishable probably belongs to Protocol.h/cpp and SymbolKind there in particular?
If that was the case I would expect this comment to be above previous line, i.e. `index::getSymbolInfo`, as that's the one doing the clang-level mapping. Whereas `indexSymbolKindToSymbolKind` does LSP mapping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89935/new/
https://reviews.llvm.org/D89935
More information about the cfe-commits
mailing list