[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

Thu Oct 22 11:31:07 PDT 2020

emankov accepted this revision.
emankov added inline comments.
This revision is now accepted and ready to land.

================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77
+    return CudaVersion::CUDA_102;
+  if (raw_version < 11010)
+    return CudaVersion::CUDA_110;
+  return CudaVersion::LATEST;
----------------
tra wrote:
> emankov wrote:
> > Please, add `CudaVersion::CUDA_111` declaration in `Cuda.h` and a corresponding `if` here. 
> > Btw, `switch` is possible here. 
> It does not serve any purpose here. 102/110 were added when clang was only accepting specific versions. Now that it will accept any newer version,  Arguably it's 102/101 that should be gone until we implement the new functionality. All of that would out of scope for this patch.
> 
> As for the switch, it would only work to match exact versions encoded in the CUDA headers, including updates, patches, special private builds etc. I do not have access to all of those versions, so I can not enumerate all of them. Range checking is more robust.
Ok, I can "live" with the latest 110 for a while till the appearing of the new functionality in clang. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89832/new/

https://reviews.llvm.org/D89832