[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D89559#2347642 <https://reviews.llvm.org/D89559#2347642>, @rjmccall wrote:

> Mangling more calling conventions when mangling function types in Itanium (except at the top level) is the right thing to do.  There's already a place to do so in the mangling.  We just haven't done this yet because a lot of those calling convention are supported by other compilers, so we need to coordinate.  So you need to check out what other compilers do (GCC, ICC) and imitate them if they're already setting a reasonable default; otherwise, I think there's a standard algorithm for generating these.
>
> Separately, the MSVC mangler should support Clang's CCs if there's a reasonable extensible rule there.  I've never been able to figure out the MVSC mangling grammar.

Same here :)

I remember there being places to mangle calling convention, I was just surprised they didn't happen in the function type here.  GCC doesn't seem to support any of the calling conventions in 64 bit, but I'll see if ICC has selected a mangling scheme.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89559/new/

https://reviews.llvm.org/D89559