[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 22 08:50:43 PDT 2020


dexonsmith updated this revision to Diff 299997.
dexonsmith added a comment.

Add the unittest (`constructTwo`) that caught the off-by-one bug, somehow missed in the last update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89913/new/

https://reviews.llvm.org/D89913

Files:
  clang/include/clang/Basic/SourceManager.h
  clang/lib/Basic/SourceManager.cpp
  clang/lib/Lex/ScratchBuffer.cpp
  clang/unittests/Basic/CMakeLists.txt
  clang/unittests/Basic/LineOffsetMappingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89913.299997.patch
Type: text/x-patch
Size: 10470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201022/1b2f6ded/attachment.bin>


More information about the cfe-commits mailing list