[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

Thu Oct 22 03:05:34 PDT 2020

kbobyrev added a comment.

In D89935#2346648 <https://reviews.llvm.org/D89935#2346648>, @kadircet wrote:

> Am I missing something? We still have:
>
>   case index::SymbolKind::Constructor:
>   case index::SymbolKind::Destructor:
>     return SymbolKind::Constructor;
>
> in Protocol.cpp. E.g. Constructors and Destructors are still classified badly. I suppose the bit around `they're all methods` are wrong though, maybe just drop that bit ?

Yeah but the LSP `SymbolKind` which we are converting to does not have a destructor type, same thing with `CompletionItemKind`, so I guess we really do treat ctors and dtors the same way from the LSP perspective, aren't we?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89935/new/

https://reviews.llvm.org/D89935