[PATCH] D89184: Support complex target features combinations

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon added a comment.

a few minor style comments that I noticed



================
Comment at: clang/lib/CodeGen/CodeGenFunction.h:4705
+    size_t SubexpressionStart = 0;
+    for (size_t i = 0; i < FeatureList.size(); ++i) {
+      char CurrentToken = FeatureList[i];
----------------
(style)
```
for (size_t i = 0, e = FeatureList.size(); i < e; ++i) {
```


================
Comment at: clang/lib/CodeGen/CodeGenFunction.h:4713
+          SubexpressionStart = i + 1;
+        InParentheses++;
+        break;
----------------
(style)
```
++InParentheses;
```


================
Comment at: clang/lib/CodeGen/CodeGenFunction.h:4716
+      case ')':
+        InParentheses--;
+        assert(InParentheses >= 0 && "Parentheses are not in pair");
----------------
```
--InParentheses;
```




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89184/new/

https://reviews.llvm.org/D89184