[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 22 01:29:43 PDT 2020
kbobyrev updated this revision to Diff 299891.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Fix typo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89935/new/
https://reviews.llvm.org/D89935
Files:
clang-tools-extra/clangd/FindSymbols.cpp
Index: clang-tools-extra/clangd/FindSymbols.cpp
===================================================================
--- clang-tools-extra/clangd/FindSymbols.cpp
+++ clang-tools-extra/clangd/FindSymbols.cpp
@@ -179,8 +179,8 @@
return llvm::None;
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This does not classify operators correctly, they are considered
+ // methods.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
DocumentSymbol SI;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89935.299891.patch
Type: text/x-patch
Size: 613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201022/734b3124/attachment.bin>
More information about the cfe-commits
mailing list