[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 21 14:13:39 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: clang/test/CodeGen/aix_alloca_align.c:2
+// RUN: %clang_cc1 -triple=powerpc-ibm-aix-xcoff -S -emit-llvm < %s | \
+// RUN:   FileCheck -check-prefix 32BIT %s
+
----------------
Minor nit: Use double-hyphen for long option and `=` instead of space between the option and the argument.


================
Comment at: clang/test/CodeGen/aix_alloca_align.c:5
+// RUN: %clang_cc1 -triple=powerpc64-ibm-aix-xcoff -S -emit-llvm < %s | \
+// RUN:   FileCheck -check-prefix 64BIT %s
+
----------------
Same comment.


================
Comment at: clang/test/CodeGen/aix_alloca_align.c:7
+
+typedef long unsigned int size_t;
+extern void *alloca(size_t __size) __attribute__((__nothrow__));
----------------
Minor comment: Use `__SIZE_TYPE__`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89910/new/

https://reviews.llvm.org/D89910



More information about the cfe-commits mailing list