[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 21 14:12:58 PDT 2020


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1687
+      return InlineResult::failure(
+          "non-stack-protected caller would inline stack-protected callee");
+
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > Is there a better way to emit an OptimizationRemark? Having this feedback in `-Rpass=inline` might be nice.
> See `llvm::setInlineRemark` for how these are set.
`InlineAdvisor::recordUnsuccessfulInliningImpl` already handles this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87956/new/

https://reviews.llvm.org/D87956



More information about the cfe-commits mailing list