[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 21 13:51:47 PDT 2020


nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1829
+
+    If a function with the ``nossp`` attribute calls a callee function that has
+    a stack protector function attribute, such as ``ssp``, ``sspreq``, or
----------------
void wrote:
> Do we care about the opposite situation where a function requiring a stack protector doesn't inline a function with the `nossp` attribute?
oh, shoot, you're right. I should have thought of that case.  I need to address that in this patch.  Ok, let me add more tests/code/docs for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87956/new/

https://reviews.llvm.org/D87956



More information about the cfe-commits mailing list