[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 21 09:26:09 PDT 2020


shafik added inline comments.


================
Comment at: clang/lib/Basic/SourceManager.cpp:1684
     bool MyInvalid = false;
     ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid);
     if (MyInvalid)
----------------
Is the `const_cast` just for this line? Maybe we can localize the cast to this line then?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89554/new/

https://reviews.llvm.org/D89554



More information about the cfe-commits mailing list