[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=<filename>

[David Zarzycki via Phabricator via cfe-commits]

davezarzycki added a comment.

A git bisect run blamed this patch for breaking the ability to build with a read-only source tree. Can we revert this or make a quick fix?

  FAIL: Clang :: CodeGen/basic-block-sections.c (3385 of 26774)
  ******************** TEST 'Clang :: CodeGen/basic-block-sections.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   /tmp/_update_lc/r/bin/clang -cc1 -internal-isystem /tmp/_update_lc/r/lib/clang/12.0.0/include -nostdsysteminc -triple x86_64 -S -o - < /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c --check-prefix=PLAIN
  : 'RUN: at line 4';   /tmp/_update_lc/r/bin/clang -cc1 -internal-isystem /tmp/_update_lc/r/lib/clang/12.0.0/include -nostdsysteminc -triple x86_64 -S -fbasic-block-sections=all -fbasic-block-sections=none -o - < /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c --check-prefix=PLAIN
  : 'RUN: at line 6';   /tmp/_update_lc/r/bin/clang -cc1 -internal-isystem /tmp/_update_lc/r/lib/clang/12.0.0/include -nostdsysteminc -triple x86_64 -S -fbasic-block-sections=all -o - < /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c --check-prefix=BB_WORLD --check-prefix=BB_ALL
  : 'RUN: at line 7';   /tmp/_update_lc/r/bin/clang -cc1 -internal-isystem /tmp/_update_lc/r/lib/clang/12.0.0/include -nostdsysteminc -triple x86_64 -S -fbasic-block-sections=list=/home/dave/ro_s/lp/clang/test/CodeGen/Inputs/basic-block-sections.funcnames -o - < /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c --check-prefix=BB_WORLD --check-prefix=BB_LIST
  : 'RUN: at line 8';   /tmp/_update_lc/r/bin/clang -cc1 -internal-isystem /tmp/_update_lc/r/lib/clang/12.0.0/include -nostdsysteminc -triple x86_64 -S -fbasic-block-sections=all -funique-basic-block-section-names -o - < /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c --check-prefix=UNIQUE
  : 'RUN: at line 9';   not /tmp/_update_lc/r/bin/clang -cc1 -internal-isystem /tmp/_update_lc/r/lib/clang/12.0.0/include -nostdsysteminc -fbasic-block-sections=list= -emit-obj /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c 2>&1 | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c --check-prefix=ERROR
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c:42:11: error: ERROR: expected string not found in input
  // ERROR: error: unable to load basic block sections function list: 'No such file or directory'
            ^
  <stdin>:1:1: note: scanning from here
  error: unable to open output file '': 'Read-only file system'
  ^
  
  Input file: <stdin>
  Check file: /home/dave/ro_s/lp/clang/test/CodeGen/basic-block-sections.c
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
            1: error: unable to open output file '': 'Read-only file system'
  check:42     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: 1 error generated.
  check:42     ~~~~~~~~~~~~~~~~~~
  >>>>>>
  
  --
  
  ********************
  ********************
  Failed Tests (1):
    Clang :: CodeGen/basic-block-sections.c
  
  
  Testing Time: 76.20s
    Unsupported      :   341
    Passed           : 26404
    Expectedly Failed:    28
    Failed           :     1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89500/new/

https://reviews.llvm.org/D89500