[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 21 03:27:39 PDT 2020


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/ProtocolVersion.h:4
+namespace remote {
+static const char *RemoteIndexProtocolVersion = "0.1.0";
+}
----------------
Not sure if having a separate file with a hard-coded string is a good idea, should I use something like `ProtocolVersion.inc` and have a macro definition there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89862/new/

https://reviews.llvm.org/D89862



More information about the cfe-commits mailing list