[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

John Brawn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 20 11:13:09 PDT 2020


john.brawn updated this revision to Diff 299420.
john.brawn edited the summary of this revision.
john.brawn added a comment.

Adjusted to give an error when the specified float abi is incompatible with the default. Was a bit trickier than I expected as it required extracting out the logic to determine the default into a separate function (we could instead emit the error in arm::getARMFloatABI but then it would be emitted several times as the function is called from several places).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89573/new/

https://reviews.llvm.org/D89573

Files:
  clang/lib/Driver/ToolChain.cpp
  clang/lib/Driver/ToolChains/Arch/ARM.cpp
  clang/lib/Driver/ToolChains/Arch/ARM.h
  clang/test/Driver/arm-float-abi-lto.c
  clang/test/Driver/arm-float-abi.c
  clang/test/Driver/arm-triple.c
  clang/test/Driver/windows-thumbv7em.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89573.299420.patch
Type: text/x-patch
Size: 16280 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201020/b5ec7895/attachment-0001.bin>


More information about the cfe-commits mailing list