[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

Tue Oct 20 11:12:59 PDT 2020

gbencze added a comment.

In D89651#2338266 <https://reviews.llvm.org/D89651#2338266>, @njames93 wrote:

> Should point out there is already a check for cert-oop57-cpp, added in D72488 <https://reviews.llvm.org/D72488>. Do these play nice with each other or should they perhaps be merged or share code?

I would certainly expect some duplicate warnings with there two checks, but as far as I can tell that check does not currently warn on using `memcmp` with non-standard-layout types. 
I personally would leave the exp42 and flp37 parts of this check as separate, because those are useful in C as well. But maybe it'd be better to move the warning for non-standard-layout types from here to the existing one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89651/new/

https://reviews.llvm.org/D89651