[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 20 08:43:46 PDT 2020


awarzynski created this revision.
Herald added subscribers: cfe-commits, dexonsmith, dang.
Herald added a project: clang.
awarzynski requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

As discussed in [1], ClangFlags::DriverOption is currently only used to
mark options that should not be forwarded to other tools via `-Xarch`
options. This patch renames this flag accordingly and updates the
corresponding driver diagnostic.

A comment in ToolChain::TranslateXarchArgs is also updated to reflect
the change. The original comment referred to isDriverOption(), which is
no longer available.

[1] http://lists.llvm.org/pipermail/cfe-dev/2020-October/066953.html


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89799

Files:
  clang/include/clang/Basic/DiagnosticDriverKinds.td
  clang/include/clang/Driver/Options.h
  clang/include/clang/Driver/Options.td
  clang/lib/Driver/ToolChain.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89799.299376.patch
Type: text/x-patch
Size: 75716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201020/45344bb3/attachment-0001.bin>


More information about the cfe-commits mailing list