[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 20 05:19:02 PDT 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

For libc++: We never manually define `_LIBCPP_BUILD_STATIC`, so libc++ always contains `__shared_weak_count::__get_deleter`.
For libc++abi: It could happen that `_LIBCPP_BUILD_STATIC` is defined through the CMake logic, however libc++abi always builds with RTTI enabled. So `!defined(_LIBCPP_NO_RTTI)` is always true anyway, and we always get the declaration of `__shared_weak_count::__get_deleter`.

I think this is a no-op change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32838/new/

https://reviews.llvm.org/D32838



More information about the cfe-commits mailing list