[PATCH] D88498: [FPEnv] Apply dynamic rounding to function body only
Serge Pavlov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 20 04:49:40 PDT 2020
sepavloff abandoned this revision.
sepavloff added a comment.
In D88498#2339630 <https://reviews.llvm.org/D88498#2339630>, @rsmith wrote:
> The tests in this patch exhibit the same behavior with and without the patch applied; I think almost all the functionality changes from here are superseded by the change to consider whether we're in a manifestly constant evaluated context.
Thank you for review and explanations!
So I am abandoning the patch.
> So my inclination is to say that the status quo (prior to this patch) is preferable behavior. The new tests look valuable.
I'll try to extract the tests to a new review item.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88498/new/
https://reviews.llvm.org/D88498
More information about the cfe-commits
mailing list