[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

Unfortunately, I could not reproduce the mentioned crash on our macOS machine. The mentioned test just passed with the output below. I gave up.

  myuser at msmarple ~/llvm3/build/release_assert $ /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8 /Users/myuser/llvm3/git/llvm-project/lldb/test/API/dotest.py -S nm -u CXXFLAGS -u CFLAGS --codesign-identity - --env LLVM_LIBS_DIR=/Users/myuser/llvm3/build/release_assert/./lib --arch x86_64 --build-dir /Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex -s /Users/myuser/llvm3/build/release_assert/lldb-test-traces --lldb-module-cache-dir /Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /Users/myuser/llvm3/build/release_assert/./bin/lldb --compiler /Users/myuser/llvm3/build/release_assert/./bin/clang --dsymutil /Users/myuser/llvm3/build/release_assert/./bin/dsymutil --filecheck /Users/myuser/llvm3/build/release_assert/./bin/FileCheck --yaml2obj /Users/myuser/llvm3/build/release_assert/./bin/yaml2obj --server /Users/myuser/llvm3/build/release_assert/./bin/debugserver --lldb-libs-dir /Users/myuser/llvm3/build/release_assert/./lib /Users/myuser/llvm3/git/llvm-project/lldb/test/API/commands/expression/import_builtin_fileid/ -p TestImportBuiltinFileID.py -t
  lldb version 12.0.99 (https://github.com/llvm/llvm-project.git revision d454328ea88562a6ec6260529a040035ab9c4a06)
    clang revision d454328ea88562a6ec6260529a040035ab9c4a06
    llvm revision d454328ea88562a6ec6260529a040035ab9c4a06
  libstdcxx tests will not be run because: Don't know how to build with libstdcxx on macosx
  Skipping following debug info categories: ['dwo']
  
  Session logs for test failures/errors/unexpected successes will go into directory '/Users/myuser/llvm3/build/release_assert/lldb-test-traces'
  Change dir to: /Users/myuser/llvm3/git/llvm-project/lldb/test/API/commands/expression/import_builtin_fileid
  runCmd: settings clear -all
  output:
  
  runCmd: settings set symbols.enable-external-lookup false
  output:
  
  runCmd: settings set target.inherit-tcc true
  output:
  
  runCmd: settings set target.auto-apply-fixits false
  output:
  
  runCmd: settings set plugin.process.gdb-remote.packet-timeout 60
  output:
  
  runCmd: settings set symbols.clang-modules-cache-path "/Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex/module-cache-lldb/lldb-api"
  output:
  
  runCmd: settings set use-color false
  output:
  
  runCmd: setting set target.prefer-dynamic-value no-dynamic-values
  output:
  
  runCmd: expr int (*DBG_CGImageGetRenderingIntent)(void *) = ((int (*)(void *))CGImageGetRenderingIntent); DBG_CGImageGetRenderingIntent((void *)0x00000000000000);
  output: (int) $0 = 0
  
  
  Ran command:
  "expr int (*DBG_CGImageGetRenderingIntent)(void *) = ((int (*)(void *))CGImageGetRenderingIntent); DBG_CGImageGetRenderingIntent((void *)0x00000000000000);"
  
  Got output:
  (int) $0 = 0
  
  Expecting sub string: "$0 = 0" (was found)
  
  <bound method SBProcess.Kill of <lldb.SBProcess; proxy of <Swig Object of type 'lldb::SBProcess *' at 0x106e3f9f0> >>: success
  
  PASS: LLDB (/Users/myuser/llvm3/build/release_assert/bin/clang-x86_64) :: test_import_builtin_fileid_gmodules (TestImportBuiltinFileID.TestImportBuiltinFileID)
  Restore dir to: /Users/myuser/llvm3/build/release_assert
  ----------------------------------------------------------------------
  Ran 1 test in 1.789s
  
  RESULT: PASSED (1 passes, 0 failures, 0 errors, 0 skipped, 0 expected failures, 0 unexpected successes)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89318/new/

https://reviews.llvm.org/D89318