[PATCH] D89579: [clangd][ObjC] Support nullability annotations

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 20 04:26:45 PDT 2020


sammccall added a comment.

Yep, let's revert to the previous state and land that, and I'll puzzle over the examples you give (because always returning false shouldn't affect behavior, just performance).

I have put together D89785 <https://reviews.llvm.org/D89785> for more general attribute support, and it has a generalization of the fix here. (It returns `false` for any node with an attribute attached).
But it's worth landing this first as it has good tests for the objc cases, and that patch has its own prerequisites and risks of regressions.
(Not a timely coincidence, rather I got curious about the AST around Attrs after seeing this patch)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89579/new/

https://reviews.llvm.org/D89579



More information about the cfe-commits mailing list