[PATCH] D89783: [format] foo.<name>.h should be the main-header for foo.<name>.cc
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 20 04:15:12 PDT 2020
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thank you!
================
Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:243
+ StringRef MatchingFileStem = matchingStem(FileName); // foo for foo.cu.cc
+ // main-header examples:
+ // 1) foo.h => foo.cc
----------------
nit: comment is internally inconsistent here, which makes it a bit hard to follow.
- either use bullets for both lists, or for neither
- either use placeholders like 'foo' or like '<name>', but not both
- list the most important/obvious examples at the top for both cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89783/new/
https://reviews.llvm.org/D89783
More information about the cfe-commits
mailing list