[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 19 17:24:41 PDT 2020


erichkeane added a comment.

In D89559#2340357 <https://reviews.llvm.org/D89559#2340357>, @rsmith wrote:

> In D89559#2339206 <https://reviews.llvm.org/D89559#2339206>, @erichkeane wrote:
>
>> Since the work is 99% the same, I think I should start doing that (emitting BOTH in the case where it matches the default member but NOT the default free function CC) in this review, then do a separate commit for the MSVC compat mode where we emit a version for ALL of the calling conventions.
>
> You'll also need an overload resolution tiebreaker to ensure that `+[]{}` and the like are not ill-formed due to ambiguity.

Right, thats a good point.  I'll make sure that is one of my tests.  Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89559/new/

https://reviews.llvm.org/D89559



More information about the cfe-commits mailing list